12 Commits

Author	SHA1	Message	Date
Jouni Malinen	d85e1fc8a5	Check os_snprintf() result more consistently - automatic 1 ... This converts os_snprintf() result validation cases to use os_snprintf_error() where the exact rule used in os_snprintf_error() was used. These changes were done automatically with spatch using the following semantic patch: @@ identifier E1; expression E2,E3,E4,E5,E6; statement S1; @@ ( E1 = os_snprintf(E2, E3, ...); | int E1 = os_snprintf(E2, E3, ...); | if (E5) E1 = os_snprintf(E2, E3, ...); else E1 = os_snprintf(E2, E3, ...); | if (E5) E1 = os_snprintf(E2, E3, ...); else if (E6) E1 = os_snprintf(E2, E3, ...); else E1 = 0; | if (E5) { ... E1 = os_snprintf(E2, E3, ...); } else { ... return -1; } | if (E5) { ... E1 = os_snprintf(E2, E3, ...); } else if (E6) { ... E1 = os_snprintf(E2, E3, ...); } else { ... return -1; } | if (E5) { ... E1 = os_snprintf(E2, E3, ...); } else { ... E1 = os_snprintf(E2, E3, ...); } ) ? os_free(E4); - if (E1 < 0 || \( E1 >= E3 \| (size_t) E1 >= E3 \| (unsigned int) E1 >= E3 \| E1 >= (int) E3 \)) + if (os_snprintf_error(E3, E1)) ( S1 | { ... } ) Signed-off-by: Jouni Malinen <j@w1.fi>	2014-12-08 11:42:07 +02:00
Jouni Malinen	c4de71cec5	EAP-FAST: Make PAC file A_ID parser easier to analyze ... Some static analyzers seem to have issues with "pos + len > end" validation (CID 62875), so convert this to "len > end - pos" to make it more obvious that len is validated against its bounds. Signed-off-by: Jouni Malinen <j@w1.fi>	2014-11-23 21:03:40 +02:00
Jouni Malinen	364182a80f	EAP-FAST: Clean up binary PAC file parser validation steps ... This was too difficult for some static analyzers (CID 62876). In addition, the pac_info_len assignment should really have explicitly validated that there is room for the two octet length field instead of trusting the following validation step to handle both this and the actual pac_info_len bounds checking. Signed-off-by: Jouni Malinen <j@w1.fi>	2014-11-23 21:03:40 +02:00
Eytan Lifshitz	c0c11afaf1	wpa_supplicant: Fix NULL dereference in eap_fast_parse_end() ... In eap_fast_parse_end(), pos might be NULL if the line doesn't contain '='. Signed-hostap: Eytan Lifshitz <eytan.lifshitz@intel.com>	2014-02-13 15:58:21 +02:00
Jouni Malinen	34d18540fc	EAP-FAST: Allow empty PAC file to be used ... Even if the PAC file does not start with the proper header line, allow the file to be used if it is empty. [Bug 423] Signed-hostap: Jouni Malinen <j@w1.fi>	2013-01-12 17:33:22 +02:00
Jouni Malinen	0f3d578efc	Remove the GPL notification from files contributed by Jouni Malinen ... Remove the GPL notification text from the files that were initially contributed by myself. Signed-hostap: Jouni Malinen <j@w1.fi>	2012-02-11 19:39:36 +02:00
Jouni Malinen	c4d7fc90a2	Fix EAP-FAST PAC file writer to avoid crash with multiple PACs ... One of the pointers to the PAC buffer was not updated after realloc and if the realloc ended up returning new pointer, the *pos pointer was still pointing at the old location (i.e., freed memory at this point).	2010-12-04 11:37:41 -08:00
Jouni Malinen	4edc521068	EAP-FAST peer: Clean up PAC writing function ... Use more explicit validation of input parameters and clean up the writes by using a local end-of-buffer variable to simplify calculations.	2010-01-10 22:04:59 +02:00
Jouni Malinen	ac987fb7de	Fixed fwrite error path in eap_fast_write_pac not to free buf ... Caller expects the buffer to be allocated on error, so eap_fast_write_pac() must be consistent with its behavior on error paths.	2008-11-01 17:09:28 +02:00
Jouni Malinen	308a4ec81a	Verify fread(), fwrite(), and system() return values ... These were starting to trigger compiler warning with recent glibc header files and gcc.	2008-10-29 19:33:24 +02:00
Jouni Malinen	fa2ec7eb63	Silenced compiler warnings on size_t printf format and shadowed variables	2008-09-27 10:46:06 +03:00
Jouni Malinen	6fc6879bd5	Re-initialize hostapd/wpa_supplicant git repository based on 0.6.3 release	2008-02-27 17:34:43 -08:00