Amazing-Mirror/fragattacks
1
0
Fork 0
mirror of https://github.com/vanhoefm/fragattacks.git synced 2024-11-25 00:38:24 -05:00
Code Issues Projects Releases Wiki Activity

OpenSSL: Fix memory leak in crypto_ecdh_init()

Browse Source 
ec_params needs to be freed before returning from the function.
Extension of this function to support BoringSSL introduced this memory
leak and that was later extended to be the only variant and apply to
OpenSSL and LibreSSL cases as well in commit c23e87d0d1 ("OpenSSL:
Replace EVP_PKEY_paramgen() with EC_KEY_new_by_curve_name()").

Fixes: f29761297b ("BoringSSL: Implement crypto_ecdh_init()")
Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
This commit is contained in:
Jouni Malinen 2019-05-08 12:16:03 +03:00 committed by Jouni Malinen
parent fb10f3bb65
commit f9cd1327ad
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/crypto/crypto_openssl.c
View File

@ -1880,7 +1880,7 @@ struct crypto_ecdh * crypto_ecdh_init(int group)
{ {
struct crypto_ecdh *ecdh; struct crypto_ecdh *ecdh;
EVP_PKEY *params = NULL; EVP_PKEY *params = NULL;
EC_KEY *ec_params; EC_KEY *ec_params = NULL;
EVP_PKEY_CTX *kctx = NULL; EVP_PKEY_CTX *kctx = NULL;
ecdh = os_zalloc(sizeof(*ecdh)); ecdh = os_zalloc(sizeof(*ecdh));
@ -1923,6 +1923,7 @@ struct crypto_ecdh * crypto_ecdh_init(int group)
} }
done: done:
EC_KEY_free(ec_params);
EVP_PKEY_free(params); EVP_PKEY_free(params);
EVP_PKEY_CTX_free(kctx); EVP_PKEY_CTX_free(kctx);