From e81f640cf5e9546c2f8e84c2323d9e8391d33680 Mon Sep 17 00:00:00 2001 From: Mathy Vanhoef Date: Mon, 27 Jul 2020 00:00:00 +0400 Subject: [PATCH] fragattack: remove some old comments --- research/fragattack.py | 3 --- research/fraginternals.py | 7 +------ 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/research/fragattack.py b/research/fragattack.py index b36fcad9d..41fd94d92 100755 --- a/research/fragattack.py +++ b/research/fragattack.py @@ -8,9 +8,6 @@ import glob, importlib from fraginternals import * -#TODO: Check that atheros is using patched firmware using debugfs -# ==> Both have caused me issues!!! Checking this automatically is *ESSENTIAL*. - # ----------------------------------- Main Function ----------------------------------- def cleanup(): diff --git a/research/fraginternals.py b/research/fraginternals.py index bedf1b6f6..66699c896 100644 --- a/research/fraginternals.py +++ b/research/fraginternals.py @@ -89,9 +89,6 @@ def freebsd_encap_eapolmsdu(p, src, dst, payload): # ----------------------------------- Vulnerability Tests ----------------------------------- -# XXX --- We should always first see how the DUT reactions to a normal packet. -# For example, Aruba only responded to DHCP after reconnecting, and -# ignored ICMP and ARP packets. REQ_ARP, REQ_ICMP, REQ_ICMPv6_RA, REQ_DHCP = range(4) def generate_request(sta, ptype, prior=2, icmp_size=None, padding=None, to_self=False): @@ -679,7 +676,7 @@ class Daemon(metaclass=abc.ABCMeta): quit(1) self.nic_iface = self.options.iface - # TODO: Check if the interfaces exist + # TODO: Check if the interfaces exists # 0. Verify whether patched drivers are being used if not self.options.no_drivercheck: @@ -807,8 +804,6 @@ class Daemon(metaclass=abc.ABCMeta): log(DEBUG, f"Passed injection self-test on interface {self.nic_mon}.") quit(1) - # TODO: Authentication and association has strict timing requirements in the Linux kernel. - # Can we make these lower somehow? def forward_hwsim(self, p, s): if p == None: return if not Dot11 in p: return