Amazing-Mirror/fragattacks
1
0
Fork 0
mirror of https://github.com/vanhoefm/fragattacks.git synced 2025-01-30 00:34:03 -05:00
Code Issues Projects Releases Wiki Activity

WNM: Use cleaner way of generating pointer to a field (CID 68099)

Browse Source 
The Action code field is in a fixed location, so the IEEE80211_HDRLEN
can be used here to clean up bounds checking to avoid false reports from
static analyzer.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2014-06-12 22:36:02 +03:00
parent 062833c67c
commit da995b2e11
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/ap/wnm_ap.c
View File

@ -376,10 +376,9 @@ int ieee802_11_rx_wnm_action_ap(struct hostapd_data *hapd,
if (len < IEEE80211_HDRLEN + 2) if (len < IEEE80211_HDRLEN + 2)
return -1; return -1;
payload = &mgmt->u.action.category; payload = ((const u8 *) mgmt) + IEEE80211_HDRLEN + 1;
payload++;
action = *payload++; action = *payload++;
plen = (((const u8 *) mgmt) + len) - payload; plen = len - IEEE80211_HDRLEN - 2;
switch (action) { switch (action) {
case WNM_BSS_TRANS_MGMT_QUERY: case WNM_BSS_TRANS_MGMT_QUERY: