From d309dd52b0d9fff04811646d6dbecb4ee071e331 Mon Sep 17 00:00:00 2001 From: Sunil Dutt Date: Fri, 31 Jul 2020 20:27:05 +0530 Subject: [PATCH] Fix the documentation for QCA_WLAN_VENDOR_ATTR_CONFIG_UDP_QOS_UPGRADE The documentation for the QCA_WLAN_VENDOR_ATTR_CONFIG_UDP_QOS_UPGRADE attribute had incorrectly specified the value of 0 (corresponding to BE) to disable the QoS upgrade. BK (1) is a lower priority AC compared to BE and if BE is used to disable the upgrade, there would be no possibility for configured UDP AC upgrade to replace BK-from-DSCP with BE. Thus, correct this by specifying that the value of BK (1) is used to disable this UDP AC upgrade. Fixes: ebd5e764f99b ("Vendor attribute to configure QoS/AC upgrade for UDP frames") Signed-off-by: Jouni Malinen --- src/common/qca-vendor.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/common/qca-vendor.h b/src/common/qca-vendor.h index df0053cff..72ebc0e1d 100644 --- a/src/common/qca-vendor.h +++ b/src/common/qca-vendor.h @@ -2267,8 +2267,9 @@ enum qca_wlan_vendor_attr_config { * DSCP value configured in the frame with the intention to only upgrade * the access category. That said, it is not intended to downgrade the * access category for the frames. - * Set the value to 0 (corresponding to BE) if the QoS upgrade needs - * to be disabled. + * Set the value to QCA_WLAN_AC_BK if the QoS upgrade needs to be + * disabled, as BK is of the lowest priority and an upgrade to it does + * not result in any changes for the frames. */ QCA_WLAN_VENDOR_ATTR_CONFIG_UDP_QOS_UPGRADE = 72,