From cce16e43f80be6f14365e1141a7d19520983e09f Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sun, 11 Mar 2018 17:04:34 +0200 Subject: [PATCH] mka: Mark ieee802_1x_kay_create_mka() ckn and cak arguments const These structures are not modified or freed (i.e., only data from them is copied), so mark the arguments const to document this a bit more clearly now that there was a memory leak in one of the callers to this function. Signed-off-by: Jouni Malinen --- src/pae/ieee802_1x_kay.c | 5 +++-- src/pae/ieee802_1x_kay.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/pae/ieee802_1x_kay.c b/src/pae/ieee802_1x_kay.c index 0fe806f19..f2dd193de 100644 --- a/src/pae/ieee802_1x_kay.c +++ b/src/pae/ieee802_1x_kay.c @@ -3269,8 +3269,9 @@ ieee802_1x_kay_deinit(struct ieee802_1x_kay *kay) * ieee802_1x_kay_create_mka - */ struct ieee802_1x_mka_participant * -ieee802_1x_kay_create_mka(struct ieee802_1x_kay *kay, struct mka_key_name *ckn, - struct mka_key *cak, u32 life, +ieee802_1x_kay_create_mka(struct ieee802_1x_kay *kay, + const struct mka_key_name *ckn, + const struct mka_key *cak, u32 life, enum mka_created_mode mode, Boolean is_authenticator) { struct ieee802_1x_mka_participant *participant; diff --git a/src/pae/ieee802_1x_kay.h b/src/pae/ieee802_1x_kay.h index 8f394fd96..b2650596c 100644 --- a/src/pae/ieee802_1x_kay.h +++ b/src/pae/ieee802_1x_kay.h @@ -241,7 +241,8 @@ void ieee802_1x_kay_deinit(struct ieee802_1x_kay *kay); struct ieee802_1x_mka_participant * ieee802_1x_kay_create_mka(struct ieee802_1x_kay *kay, - struct mka_key_name *ckn, struct mka_key *cak, + const struct mka_key_name *ckn, + const struct mka_key *cak, u32 life, enum mka_created_mode mode, Boolean is_authenticator); void ieee802_1x_kay_delete_mka(struct ieee802_1x_kay *kay,