From c7cc80fbc8f917f239fbc6280b1e4dbe96c8372d Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Tue, 11 Feb 2020 06:33:24 +0200 Subject: [PATCH] DPP: Reset DPP_AUTH_INIT netrole back to STA by default Previously DPP_AUTH_INIT command update wpa_s->dpp_netrole only if the netrole parameter was included. This could leave AP or configurator network in place for the next DPP_AUTH_INIT command. This would be unexpected behavior, so reset wpa_s->dpp_netrole back to the DPP_NETROLE_STA default if no explicit netrole parameter is included. Signed-off-by: Jouni Malinen --- wpa_supplicant/dpp_supplicant.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/wpa_supplicant/dpp_supplicant.c b/wpa_supplicant/dpp_supplicant.c index 0811ab300..0a13213b0 100644 --- a/wpa_supplicant/dpp_supplicant.c +++ b/wpa_supplicant/dpp_supplicant.c @@ -751,6 +751,8 @@ int wpas_dpp_auth_init(struct wpa_supplicant *wpa_s, const char *cmd) wpa_s->dpp_netrole = DPP_NETROLE_CONFIGURATOR; else wpa_s->dpp_netrole = DPP_NETROLE_STA; + } else { + wpa_s->dpp_netrole = DPP_NETROLE_STA; } pos = os_strstr(cmd, " neg_freq=");