From bcf66493cf189f8fe0ee3281854cd4a5a1354c53 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sun, 5 Feb 2017 21:52:26 +0200 Subject: [PATCH] Fix estimated throughput based skip-roam case Commit 8d1e693186336f85bf5d86bd094b5c9bd6f8fd02 ('Use estimated throughput to avoid signal based roaming decision') added a check for the current BSS estimated throughput being significantly higher than the selected BSS estimated throughput. However, this case for skipping a roam used "return 1" which actually allows the roam. Fix this by returning 0 in this case. Signed-off-by: Jouni Malinen --- wpa_supplicant/events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c index 76805e08c..24dbd3e2d 100644 --- a/wpa_supplicant/events.c +++ b/wpa_supplicant/events.c @@ -1561,7 +1561,7 @@ static int wpa_supplicant_need_to_roam(struct wpa_supplicant *wpa_s, if (current_bss->est_throughput > selected->est_throughput + 5000) { wpa_dbg(wpa_s, MSG_DEBUG, "Skip roam - Current BSS has better estimated throughput"); - return 1; + return 0; } cur_est = current_bss->est_throughput;