Amazing-Mirror/fragattacks
1
0
Fork 0
mirror of https://github.com/vanhoefm/fragattacks.git synced 2025-01-31 09:14:03 -05:00
Code Issues Projects Releases Wiki Activity

EAP-TEAP server: Fix Crypto-Binding check in PAC no-inner-auth case

Browse Source 
The Crypto-Binding TLV is included without Intermediate-Result TLV in
this sequence since the server is skipping all inner authentication
methods and is only sending out Result TLV with the Crypto-Binding TLV.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2019-08-20 02:11:31 +03:00
parent 10e105230a
commit 986033ff3d
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/eap_server/eap_server_teap.c
View File

@ -57,6 +57,7 @@ struct eap_teap_data {
char *srv_id_info; char *srv_id_info;
int anon_provisioning; int anon_provisioning;
int skipped_inner_auth;
int send_new_pac; /* server triggered re-keying of Tunnel PAC */ int send_new_pac; /* server triggered re-keying of Tunnel PAC */
struct wpabuf *pending_phase2_resp; struct wpabuf *pending_phase2_resp;
struct wpabuf *server_outer_tlvs; struct wpabuf *server_outer_tlvs;
@ -1529,6 +1530,7 @@ static void eap_teap_process_phase2_tlvs(struct eap_sm *sm,
} }
if (sm->cfg->eap_teap_auth != 1 && if (sm->cfg->eap_teap_auth != 1 &&
!data->skipped_inner_auth &&
tlv.iresult != TEAP_STATUS_SUCCESS) { tlv.iresult != TEAP_STATUS_SUCCESS) {
wpa_printf(MSG_DEBUG, wpa_printf(MSG_DEBUG,
"EAP-TEAP: Crypto-Binding TLV without intermediate Success Result"); "EAP-TEAP: Crypto-Binding TLV without intermediate Success Result");
@ -1738,6 +1740,7 @@ static int eap_teap_process_phase2_start(struct eap_sm *sm,
} else if (sm->cfg->eap_teap_pac_no_inner) { } else if (sm->cfg->eap_teap_pac_no_inner) {
wpa_printf(MSG_DEBUG, wpa_printf(MSG_DEBUG,
"EAP-TEAP: Used PAC and identity already known - skip inner auth"); "EAP-TEAP: Used PAC and identity already known - skip inner auth");
data->skipped_inner_auth = 1;
/* FIX: Need to derive CMK here. However, how is that /* FIX: Need to derive CMK here. However, how is that
* supposed to be done? RFC 7170 does not tell that for * supposed to be done? RFC 7170 does not tell that for
* the no-inner-auth case. */ * the no-inner-auth case. */