Amazing-Mirror/fragattacks
1
0
Fork 0
mirror of https://github.com/vanhoefm/fragattacks.git synced 2024-11-29 02:38:22 -05:00
Code Issues Projects Releases Wiki Activity

P2PS: Fix attribute addition in p2p_buf_add_service_instance()

Browse Source 
Fix a condition when Advertised Service Info Attribute is added to
a probe response in p2p_buf_add_service_instance(). The issue is
that a 'found' value is increased even if 'test' and 'adv->hash' hashes
are different. As result 'found' may have a non-zero value when an
attribute data length is 0. In this cause an empty attribute is about to
be added. Fixing it by eliminating 'found' and checking 'total_len'
containing a real number of bytes added to Advertised Service Info
Attribute.

This fixes an issue from commit 50a9efe713
('P2PS: Fix Probe Response frame building in error cases').

Signed-off-by: Max Stepanov <Max.Stepanov@intel.com>
This commit is contained in:
Stepanov, Max 2015-06-23 13:47:59 +00:00 committed by Jouni Malinen
parent a9ea609ce8
commit 8c43ef8449
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/p2p/p2p_build.c
View File

@ -557,7 +557,7 @@ void p2p_buf_add_service_instance(struct wpabuf *buf, struct p2p_data *p2p,
struct p2ps_advertisement *adv_list) struct p2ps_advertisement *adv_list)
{ {
struct p2ps_advertisement *adv; struct p2ps_advertisement *adv;
int p2ps_wildcard, found = 0; int p2ps_wildcard;
size_t total_len; size_t total_len;
struct wpabuf *tmp_buf = NULL; struct wpabuf *tmp_buf = NULL;
u8 *pos, *attr_len, *ie_len = NULL; u8 *pos, *attr_len, *ie_len = NULL;
@ -593,7 +593,6 @@ void p2p_buf_add_service_instance(struct wpabuf *buf, struct p2p_data *p2p,
/* org.wi-fi.wfds match found */ /* org.wi-fi.wfds match found */
p2p_buf_add_service_info(tmp_buf, p2p, 0, 0, P2PS_WILD_HASH_STR, p2p_buf_add_service_info(tmp_buf, p2p, 0, 0, P2PS_WILD_HASH_STR,
&ie_len, &pos, &total_len, attr_len); &ie_len, &pos, &total_len, attr_len);
found++;
} }
/* add advertised service info of matching services */ /* add advertised service info of matching services */
@ -613,12 +612,12 @@ void p2p_buf_add_service_instance(struct wpabuf *buf, struct p2p_data *p2p,
&total_len, &total_len,
attr_len)) attr_len))
break; break;
found++;
test += P2PS_HASH_LEN; test += P2PS_HASH_LEN;
} }
} }
if (found) if (total_len)
wpabuf_put_buf(buf, tmp_buf); wpabuf_put_buf(buf, tmp_buf);
wpabuf_free(tmp_buf); wpabuf_free(tmp_buf);
} }