From 5a631ad2c2ecd0143d2137fc6086d3c82129e063 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Fri, 28 Nov 2014 16:28:36 +0200 Subject: [PATCH] tests: Optimize ap_open_unexpected_assoc_event Replace fixed sleep with waiting for a disconnection event. In addition, remove unnecessary use of sudo. Signed-off-by: Jouni Malinen --- tests/hwsim/test_ap_open.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/hwsim/test_ap_open.py b/tests/hwsim/test_ap_open.py index c5c0a3e95..ad24cdd38 100644 --- a/tests/hwsim/test_ap_open.py +++ b/tests/hwsim/test_ap_open.py @@ -146,22 +146,22 @@ def test_ap_open_unexpected_assoc_event(dev, apdev): hapd = hostapd.add_ap(apdev[0]['ifname'], { "ssid": "open" }) dev[0].connect("open", key_mgmt="NONE", scan_freq="2412") dev[0].request("DISCONNECT") - time.sleep(0.1) + dev[0].wait_event(["CTRL-EVENT-DISCONNECTED"], timeout=15) dev[0].dump_monitor() # This will be accepted due to matching network - subprocess.call(['sudo', 'iw', 'dev', dev[0].ifname, 'connect', 'open', - "2412", apdev[0]['bssid']]) + subprocess.call(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412", + apdev[0]['bssid']]) ev = dev[0].wait_event(["CTRL-EVENT-CONNECTED"], timeout=15) if ev is None: raise Exception("Association with the AP timed out") dev[0].dump_monitor() dev[0].request("REMOVE_NETWORK all") - time.sleep(0.1) + dev[0].wait_event(["CTRL-EVENT-DISCONNECTED"], timeout=5) dev[0].dump_monitor() # This will result in disconnection due to no matching network - subprocess.call(['sudo', 'iw', 'dev', dev[0].ifname, 'connect', 'open', - "2412", apdev[0]['bssid']]) + subprocess.call(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412", + apdev[0]['bssid']]) ev = dev[0].wait_event(["CTRL-EVENT-DISCONNECTED"], timeout=15) if ev is None: raise Exception("Disconnection with the AP timed out")