From 546680f81a903b7bd96eecb3ee60a363fe9d1c33 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Tue, 27 Dec 2016 12:24:02 +0200 Subject: [PATCH] hostapd: Do not update dtim_period with invalid value Previously, the update command was rejected, but the actual value was updated. Signed-off-by: Jouni Malinen --- hostapd/config_file.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hostapd/config_file.c b/hostapd/config_file.c index a115c1efe..8ebdd7b3b 100644 --- a/hostapd/config_file.c +++ b/hostapd/config_file.c @@ -2750,12 +2750,14 @@ static int hostapd_config_fill(struct hostapd_config *conf, } #endif /* CONFIG_ACS */ } else if (os_strcmp(buf, "dtim_period") == 0) { - bss->dtim_period = atoi(pos); - if (bss->dtim_period < 1 || bss->dtim_period > 255) { + int val = atoi(pos); + + if (val < 1 || val > 255) { wpa_printf(MSG_ERROR, "Line %d: invalid dtim_period %d", - line, bss->dtim_period); + line, val); return 1; } + bss->dtim_period = val; } else if (os_strcmp(buf, "bss_load_update_period") == 0) { bss->bss_load_update_period = atoi(pos); if (bss->bss_load_update_period < 0 ||