Amazing-Mirror/fragattacks
1
0
Fork 0
mirror of https://github.com/vanhoefm/fragattacks.git synced 2025-02-20 02:53:03 -05:00
Code Issues Projects Releases Wiki Activity

WPS UPnP: Do not update Beacon frames unnecessarily on subscription removal

Browse Source 
There is no need to update the WPS IE in Beacon frames when a
subscription is removed if that subscription is not for an actual
selected registrar. For example, this gets rids of unnecessary driver
operations when a subscription request gets rejected when parsing the
callback URLs.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
This commit is contained in:
Jouni Malinen 2020-06-04 21:04:59 +03:00 committed by Jouni Malinen
parent c85b39ec50
commit 40240735bd
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wps/wps_upnp_ap.c
View File

@ -76,8 +76,10 @@ int upnp_er_set_selected_registrar(struct wps_registrar *reg,
void upnp_er_remove_notification(struct wps_registrar *reg, void upnp_er_remove_notification(struct wps_registrar *reg,
struct subscription *s) struct subscription *s)
{ {
bool was_sel_reg = s->selected_registrar;
s->selected_registrar = 0; s->selected_registrar = 0;
eloop_cancel_timeout(upnp_er_set_selected_timeout, s, reg); eloop_cancel_timeout(upnp_er_set_selected_timeout, s, reg);
if (reg) if (reg && was_sel_reg)
wps_registrar_selected_registrar_changed(reg, 0); wps_registrar_selected_registrar_changed(reg, 0);
} }