From 22d8bb04d94c2311defc2d3faa0ea9495e2d484f Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sat, 8 Dec 2018 16:48:33 +0200 Subject: [PATCH] WMM AC: Do not write ERROR level log entries when WMM AC is not in use These two wpa_printf() calls with MSG_ERROR level could be reached when connecting without (Re)Association Response frame elements being available. That would be the case for wired connections and IBSS. Those cases are not supposed to use WMM AC in the first place, so do not confuse logs with ERROR messages in them for normal conditions. Signed-off-by: Jouni Malinen --- wpa_supplicant/wmm_ac.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/wpa_supplicant/wmm_ac.c b/wpa_supplicant/wmm_ac.c index a88cc46f3..1b78c5f61 100644 --- a/wpa_supplicant/wmm_ac.c +++ b/wpa_supplicant/wmm_ac.c @@ -471,13 +471,8 @@ static int wmm_ac_init(struct wpa_supplicant *wpa_s, const u8 *ies, return -1; } - if (!ies) { - wpa_printf(MSG_ERROR, "WMM AC: Missing IEs"); - return -1; - } - - if (!(wmm_params->info_bitmap & WMM_PARAMS_UAPSD_QUEUES_INFO)) { - wpa_printf(MSG_DEBUG, "WMM AC: Missing U-APSD configuration"); + if (!ies || !(wmm_params->info_bitmap & WMM_PARAMS_UAPSD_QUEUES_INFO)) { + /* WMM AC not in use for this connection */ return -1; }