From 12129dda8e5351d673d56f43812b81b71810b397 Mon Sep 17 00:00:00 2001 From: Jonathan Afek Date: Thu, 23 Jun 2016 20:16:29 +0300 Subject: [PATCH] tests: Use cmd_execute() for iw connect command The hwsim tests used to execute shell commands in the tests using the subprocess python module. Use the cmd_execute() general function for executing "iw connect ..." commands so that this would also work on remote setups. Signed-off-by: Jonathan Afek --- tests/hwsim/test_ap_open.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/hwsim/test_ap_open.py b/tests/hwsim/test_ap_open.py index fe52956bb..69d2564c4 100644 --- a/tests/hwsim/test_ap_open.py +++ b/tests/hwsim/test_ap_open.py @@ -160,8 +160,8 @@ def test_ap_open_unexpected_assoc_event(dev, apdev): dev[0].wait_disconnected(timeout=15) dev[0].dump_monitor() # This will be accepted due to matching network - subprocess.call(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412", - apdev[0]['bssid']]) + dev[0].cmd_execute(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412", + apdev[0]['bssid']]) dev[0].wait_connected(timeout=15) dev[0].dump_monitor() @@ -169,8 +169,8 @@ def test_ap_open_unexpected_assoc_event(dev, apdev): dev[0].wait_disconnected(timeout=5) dev[0].dump_monitor() # This will result in disconnection due to no matching network - subprocess.call(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412", - apdev[0]['bssid']]) + dev[0].cmd_execute(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412", + apdev[0]['bssid']]) dev[0].wait_disconnected(timeout=15) def test_ap_bss_load(dev, apdev):