Amazing-Mirror/fragattacks
1
0
Fork 0
mirror of https://github.com/vanhoefm/fragattacks.git synced 2025-01-30 08:44:03 -05:00
Code Issues Projects Releases Wiki Activity

WPS: Fix PBC session overlap detection to use Device Password Id

Browse Source 
Active PBC mode is indicated by Device Password Id == 4, not Config Methods
attribute.
This commit is contained in:
Jouni Malinen 2010-04-03 18:34:44 +02:00 committed by Jouni Malinen
parent f8130b07bb
commit 11356a2ab5
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/wps/wps_registrar.c
View File

@ -759,7 +759,6 @@ void wps_registrar_probe_req_rx(struct wps_registrar *reg, const u8 *addr,
const struct wpabuf *wps_data) const struct wpabuf *wps_data)
{ {
struct wps_parse_attr attr; struct wps_parse_attr attr;
u16 methods;
wpa_hexdump_buf(MSG_MSGDUMP, wpa_hexdump_buf(MSG_MSGDUMP,
"WPS: Probe Request with WPS data received", "WPS: Probe Request with WPS data received",
@ -779,7 +778,13 @@ void wps_registrar_probe_req_rx(struct wps_registrar *reg, const u8 *addr,
return; return;
} }
if (reg->enrollee_seen_cb && attr.dev_password_id && attr.uuid_e && if (attr.dev_password_id == NULL) {
wpa_printf(MSG_DEBUG, "WPS: No Device Password Id attribute "
"in Probe Request");
return;
}
if (reg->enrollee_seen_cb && attr.uuid_e &&
attr.primary_dev_type && attr.request_type) { attr.primary_dev_type && attr.request_type) {
char *dev_name = NULL; char *dev_name = NULL;
if (attr.dev_name) { if (attr.dev_name) {
@ -797,8 +802,7 @@ void wps_registrar_probe_req_rx(struct wps_registrar *reg, const u8 *addr,
os_free(dev_name); os_free(dev_name);
} }
methods = WPA_GET_BE16(attr.config_methods); if (WPA_GET_BE16(attr.dev_password_id) != DEV_PW_PUSHBUTTON)
if (!(methods & WPS_CONFIG_PUSHBUTTON))
return; /* Not PBC */ return; /* Not PBC */
wpa_printf(MSG_DEBUG, "WPS: Probe Request for PBC received from " wpa_printf(MSG_DEBUG, "WPS: Probe Request for PBC received from "