Amazing-Mirror/fragattacks
1
0
Fork 0
mirror of https://github.com/vanhoefm/fragattacks.git synced 2025-01-18 19:04:02 -05:00
Code Issues Projects Releases Wiki Activity

EAP peer config: Move ocsp param to phase1/phase2

Browse Source 
OCSP configuration is applicable to each instance of TLS-based
authentication and as such, the configuration might need to be different
for Phase 1 and Phase 2. Move ocsp into struct eap_peer_cert_config and
add a separate ocsp2 network profile parameter to set this for Phase 2.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2019-09-01 16:07:58 +03:00
parent e0ee87c706
commit 043de65f1c
6 changed files with 21 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/eap_peer/eap_config.h
View File

@ -284,6 +284,15 @@ struct eap_peer_cert_config {
* This is used if the CA certificate for EAP-TLS is on a smartcard. * This is used if the CA certificate for EAP-TLS is on a smartcard.
*/ */
char *ca_cert_id; char *ca_cert_id;
/**
* ocsp - Whether to use/require OCSP to check server certificate
*
* 0 = do not use OCSP stapling (TLS certificate status extension)
* 1 = try to use OCSP stapling, but not require response
* 2 = require valid OCSP stapling response
*/
int ocsp;
}; };
/** /**
@ -633,15 +642,6 @@ struct eap_peer_config {
*/ */
u32 flags; u32 flags;
/**
* ocsp - Whether to use/require OCSP to check server certificate
*
* 0 = do not use OCSP stapling (TLS certificate status extension)
* 1 = try to use OCSP stapling, but not require response
* 2 = require valid OCSP stapling response
*/
int ocsp;
/** /**
* external_sim_resp - Response from external SIM processing * external_sim_resp - Response from external SIM processing
* *

12
src/eap_peer/eap_tls_common.c
View File

@ -125,6 +125,12 @@ static void eap_tls_cert_params_from_conf(struct tls_connection_params *params,
params->key_id = config->key_id; params->key_id = config->key_id;
params->cert_id = config->cert_id; params->cert_id = config->cert_id;
params->ca_cert_id = config->ca_cert_id; params->ca_cert_id = config->ca_cert_id;
if (config->ocsp)
params->flags |= TLS_CONN_REQUEST_OCSP;
if (config->ocsp >= 2)
params->flags |= TLS_CONN_REQUIRE_OCSP;
if (config->ocsp == 3)
params->flags |= TLS_CONN_REQUIRE_OCSP_ALL;
} }
@ -233,12 +239,6 @@ static int eap_tls_init_connection(struct eap_sm *sm,
{ {
int res; int res;
if (config->ocsp)
params->flags |= TLS_CONN_REQUEST_OCSP;
if (config->ocsp >= 2)
params->flags |= TLS_CONN_REQUIRE_OCSP;
if (config->ocsp == 3)
params->flags |= TLS_CONN_REQUIRE_OCSP_ALL;
data->conn = tls_connection_init(data->ssl_ctx); data->conn = tls_connection_init(data->ssl_ctx);
if (data->conn == NULL) { if (data->conn == NULL) {
wpa_printf(MSG_INFO, "SSL: Failed to initialize new TLS " wpa_printf(MSG_INFO, "SSL: Failed to initialize new TLS "

3
wpa_supplicant/config.c
View File

@ -2443,7 +2443,8 @@ static const struct parse_data ssid_fields[] = {
{ INT(eap_workaround) }, { INT(eap_workaround) },
{ STRe(pac_file, pac_file) }, { STRe(pac_file, pac_file) },
{ INTe(fragment_size, fragment_size) }, { INTe(fragment_size, fragment_size) },
{ INTe(ocsp, ocsp) }, { INTe(ocsp, cert.ocsp) },
{ INTe(ocsp2, phase2_cert.ocsp) },
#endif /* IEEE8021X_EAPOL */ #endif /* IEEE8021X_EAPOL */
#ifdef CONFIG_MESH #ifdef CONFIG_MESH
{ INT_RANGE(mode, 0, 5) }, { INT_RANGE(mode, 0, 5) },

3
wpa_supplicant/config_file.c
View File

@ -826,7 +826,8 @@ static void wpa_config_write_network(FILE *f, struct wpa_ssid *ssid)
INT_DEF(eap_workaround, DEFAULT_EAP_WORKAROUND); INT_DEF(eap_workaround, DEFAULT_EAP_WORKAROUND);
STR(pac_file); STR(pac_file);
INT_DEFe(fragment_size, fragment_size, DEFAULT_FRAGMENT_SIZE); INT_DEFe(fragment_size, fragment_size, DEFAULT_FRAGMENT_SIZE);
INTe(ocsp, ocsp); INTe(ocsp, cert.ocsp);
INTe(ocsp2, phase2_cert.ocsp);
INT_DEFe(sim_num, sim_num, DEFAULT_USER_SELECTED_SIM); INT_DEFe(sim_num, sim_num, DEFAULT_USER_SELECTED_SIM);
#endif /* IEEE8021X_EAPOL */ #endif /* IEEE8021X_EAPOL */
INT(mode); INT(mode);

2
wpa_supplicant/interworking.c
View File

@ -1554,7 +1554,7 @@ static int interworking_set_eap_params(struct wpa_ssid *ssid,
cred->domain_suffix_match) < 0) cred->domain_suffix_match) < 0)
return -1; return -1;
ssid->eap.ocsp = cred->ocsp; ssid->eap.cert.ocsp = cred->ocsp;
return 0; return 0;
} }

1
wpa_supplicant/wpa_supplicant.conf
View File

@ -1323,6 +1323,7 @@ fast_reauth=1
# certificate. See altsubject_match documentation for more details. # certificate. See altsubject_match documentation for more details.
# domain_suffix_match2: Constraint for server domain name. See # domain_suffix_match2: Constraint for server domain name. See
# domain_suffix_match for more details. # domain_suffix_match for more details.
# ocsp2: See ocsp for more details.
# #
# fragment_size: Maximum EAP fragment size in bytes (default 1398). # fragment_size: Maximum EAP fragment size in bytes (default 1398).
# This value limits the fragment size for EAP methods that support # This value limits the fragment size for EAP methods that support