fragattacks/src/wps/ndef.c

205 lines
4.8 KiB
C
Raw Normal View History

2009-03-06 09:16:22 -05:00
/*
* NDEF(NFC Data Exchange Format) routines for Wi-Fi Protected Setup
* Reference is "NFCForum-TS-NDEF_1.0 2006-07-24".
* Copyright (c) 2009-2012, Masashi Honma <masashi.honma@gmail.com>
2009-03-06 09:16:22 -05:00
*
* This software may be distributed under the terms of the BSD license.
* See README for more details.
2009-03-06 09:16:22 -05:00
*/
#include "includes.h"
#include "common.h"
#include "wps/wps.h"
#define FLAG_MESSAGE_BEGIN (1 << 7)
#define FLAG_MESSAGE_END (1 << 6)
#define FLAG_CHUNK (1 << 5)
#define FLAG_SHORT_RECORD (1 << 4)
#define FLAG_ID_LENGTH_PRESENT (1 << 3)
#define FLAG_TNF_NFC_FORUM (0x01)
2009-03-06 09:16:22 -05:00
#define FLAG_TNF_RFC2046 (0x02)
struct ndef_record {
const u8 *type;
const u8 *id;
const u8 *payload;
2009-03-06 09:16:22 -05:00
u8 type_length;
u8 id_length;
u32 payload_length;
u32 total_length;
};
static const char wifi_handover_type[] = "application/vnd.wfa.wsc";
static const char p2p_handover_type[] = "application/vnd.wfa.p2p";
2009-03-06 09:16:22 -05:00
static int ndef_parse_record(const u8 *data, u32 size,
struct ndef_record *record)
2009-03-06 09:16:22 -05:00
{
const u8 *pos = data + 1;
2009-03-06 09:16:22 -05:00
if (size < 2)
return -1;
record->type_length = *pos++;
if (data[0] & FLAG_SHORT_RECORD) {
if (size < 3)
return -1;
record->payload_length = *pos++;
} else {
u32 len;
2009-03-06 09:16:22 -05:00
if (size < 6)
return -1;
len = WPA_GET_BE32(pos);
if (len > size - 6 || len > 20000)
NFC: Fix payload length validation in NDEF record parser It was possible for the 32-bit record->total_length value to end up wrapping around due to integer overflow if the longer form of payload length field is used and record->payload_length gets a value close to 2^32. This could result in ndef_parse_record() accepting a too large payload length value and the record type filter reading up to about 20 bytes beyond the end of the buffer and potentially killing the process. This could also result in an attempt to allocate close to 2^32 bytes of heap memory and if that were to succeed, a buffer read overflow of the same length which would most likely result in the process termination. In case of record->total_length ending up getting the value 0, there would be no buffer read overflow, but record parsing would result in an infinite loop in ndef_parse_records(). Any of these error cases could potentially be used for denial of service attacks over NFC by using a malformed NDEF record on an NFC Tag or sending them during NFC connection handover if the application providing the NDEF message to hostapd/wpa_supplicant did no validation of the received records. While such validation is likely done in the NFC stack that needs to parse the NFC messages before further processing, hostapd/wpa_supplicant better be prepared for any data being included here. Fix this by validating record->payload_length value in a way that detects integer overflow. (CID 122668) Signed-off-by: Jouni Malinen <j@w1.fi>
2015-07-07 14:57:28 -04:00
return -1;
record->payload_length = len;
2009-03-06 09:16:22 -05:00
pos += sizeof(u32);
}
if (data[0] & FLAG_ID_LENGTH_PRESENT) {
if ((int) size < pos - data + 1)
return -1;
record->id_length = *pos++;
} else
record->id_length = 0;
record->type = record->type_length == 0 ? NULL : pos;
pos += record->type_length;
record->id = record->id_length == 0 ? NULL : pos;
pos += record->id_length;
record->payload = record->payload_length == 0 ? NULL : pos;
pos += record->payload_length;
record->total_length = pos - data;
NFC: Fix payload length validation in NDEF record parser It was possible for the 32-bit record->total_length value to end up wrapping around due to integer overflow if the longer form of payload length field is used and record->payload_length gets a value close to 2^32. This could result in ndef_parse_record() accepting a too large payload length value and the record type filter reading up to about 20 bytes beyond the end of the buffer and potentially killing the process. This could also result in an attempt to allocate close to 2^32 bytes of heap memory and if that were to succeed, a buffer read overflow of the same length which would most likely result in the process termination. In case of record->total_length ending up getting the value 0, there would be no buffer read overflow, but record parsing would result in an infinite loop in ndef_parse_records(). Any of these error cases could potentially be used for denial of service attacks over NFC by using a malformed NDEF record on an NFC Tag or sending them during NFC connection handover if the application providing the NDEF message to hostapd/wpa_supplicant did no validation of the received records. While such validation is likely done in the NFC stack that needs to parse the NFC messages before further processing, hostapd/wpa_supplicant better be prepared for any data being included here. Fix this by validating record->payload_length value in a way that detects integer overflow. (CID 122668) Signed-off-by: Jouni Malinen <j@w1.fi>
2015-07-07 14:57:28 -04:00
if (record->total_length > size ||
record->total_length < record->payload_length)
2009-03-06 09:16:22 -05:00
return -1;
return 0;
}
static struct wpabuf * ndef_parse_records(const struct wpabuf *buf,
2009-03-06 09:16:22 -05:00
int (*filter)(struct ndef_record *))
{
struct ndef_record record;
int len = wpabuf_len(buf);
const u8 *data = wpabuf_head(buf);
2009-03-06 09:16:22 -05:00
while (len > 0) {
if (ndef_parse_record(data, len, &record) < 0) {
wpa_printf(MSG_ERROR, "NDEF : Failed to parse");
return NULL;
}
if (filter == NULL || filter(&record))
return wpabuf_alloc_copy(record.payload,
record.payload_length);
data += record.total_length;
len -= record.total_length;
}
wpa_printf(MSG_ERROR, "NDEF : Record not found");
return NULL;
}
static struct wpabuf * ndef_build_record(u8 flags, const void *type,
2009-03-06 09:16:22 -05:00
u8 type_length, void *id,
u8 id_length,
const struct wpabuf *payload)
2009-03-06 09:16:22 -05:00
{
struct wpabuf *record;
size_t total_len;
int short_record;
u8 local_flag;
size_t payload_length = wpabuf_len(payload);
2009-03-06 09:16:22 -05:00
short_record = payload_length < 256 ? 1 : 0;
total_len = 2; /* flag + type length */
/* payload length */
total_len += short_record ? sizeof(u8) : sizeof(u32);
if (id_length > 0)
total_len += 1;
total_len += type_length + id_length + payload_length;
record = wpabuf_alloc(total_len);
if (record == NULL) {
wpa_printf(MSG_ERROR, "NDEF : Failed to allocate "
"record for build");
return NULL;
}
local_flag = flags;
if (id_length > 0)
local_flag |= FLAG_ID_LENGTH_PRESENT;
if (short_record)
local_flag |= FLAG_SHORT_RECORD;
wpabuf_put_u8(record, local_flag);
wpabuf_put_u8(record, type_length);
if (short_record)
wpabuf_put_u8(record, payload_length);
else
wpabuf_put_be32(record, payload_length);
if (id_length > 0)
wpabuf_put_u8(record, id_length);
wpabuf_put_data(record, type, type_length);
wpabuf_put_data(record, id, id_length);
wpabuf_put_buf(record, payload);
2009-03-06 09:16:22 -05:00
return record;
}
static int wifi_filter(struct ndef_record *record)
{
if (record->type == NULL ||
record->type_length != os_strlen(wifi_handover_type))
2009-03-06 09:16:22 -05:00
return 0;
if (os_memcmp(record->type, wifi_handover_type,
os_strlen(wifi_handover_type)) != 0)
return 0;
return 1;
}
struct wpabuf * ndef_parse_wifi(const struct wpabuf *buf)
2009-03-06 09:16:22 -05:00
{
return ndef_parse_records(buf, wifi_filter);
}
struct wpabuf * ndef_build_wifi(const struct wpabuf *buf)
2009-03-06 09:16:22 -05:00
{
return ndef_build_record(FLAG_MESSAGE_BEGIN | FLAG_MESSAGE_END |
FLAG_TNF_RFC2046, wifi_handover_type,
os_strlen(wifi_handover_type), NULL, 0, buf);
2009-03-06 09:16:22 -05:00
}
static int p2p_filter(struct ndef_record *record)
{
if (record->type == NULL ||
record->type_length != os_strlen(p2p_handover_type))
return 0;
if (os_memcmp(record->type, p2p_handover_type,
os_strlen(p2p_handover_type)) != 0)
return 0;
return 1;
}
struct wpabuf * ndef_parse_p2p(const struct wpabuf *buf)
{
return ndef_parse_records(buf, p2p_filter);
}
struct wpabuf * ndef_build_p2p(const struct wpabuf *buf)
{
return ndef_build_record(FLAG_MESSAGE_BEGIN | FLAG_MESSAGE_END |
FLAG_TNF_RFC2046, p2p_handover_type,
os_strlen(p2p_handover_type), NULL, 0, buf);
}