fragattacks/src/p2p/p2p_go_neg.c

1163 lines
34 KiB
C
Raw Normal View History

2010-07-18 17:30:25 -04:00
/*
* Wi-Fi Direct - P2P Group Owner Negotiation
* Copyright (c) 2009-2010, Atheros Communications
*
* This software may be distributed under the terms of the BSD license.
* See README for more details.
2010-07-18 17:30:25 -04:00
*/
#include "includes.h"
#include "common.h"
#include "common/ieee802_11_defs.h"
#include "wps/wps_defs.h"
#include "p2p_i.h"
#include "p2p.h"
static int p2p_go_det(u8 own_intent, u8 peer_value)
{
u8 peer_intent = peer_value >> 1;
if (own_intent == peer_intent) {
if (own_intent == P2P_MAX_GO_INTENT)
return -1; /* both devices want to become GO */
/* Use tie breaker bit to determine GO */
return (peer_value & 0x01) ? 0 : 1;
}
return own_intent > peer_intent;
}
int p2p_peer_channels_check(struct p2p_data *p2p, struct p2p_channels *own,
struct p2p_device *dev,
const u8 *channel_list, size_t channel_list_len)
{
const u8 *pos, *end;
struct p2p_channels *ch;
size_t channels;
struct p2p_channels intersection;
ch = &dev->channels;
os_memset(ch, 0, sizeof(*ch));
pos = channel_list;
end = channel_list + channel_list_len;
if (end - pos < 3)
return -1;
os_memcpy(dev->country, pos, 3);
wpa_hexdump_ascii(MSG_DEBUG, "P2P: Peer country", pos, 3);
if (pos[2] != 0x04 && os_memcmp(pos, p2p->cfg->country, 2) != 0) {
p2p_info(p2p, "Mismatching country (ours=%c%c peer's=%c%c)",
2010-07-18 17:30:25 -04:00
p2p->cfg->country[0], p2p->cfg->country[1],
pos[0], pos[1]);
return -1;
}
pos += 3;
while (pos + 2 < end) {
struct p2p_reg_class *cl = &ch->reg_class[ch->reg_classes];
cl->reg_class = *pos++;
if (pos + 1 + pos[0] > end) {
p2p_info(p2p, "Invalid peer Channel List");
2010-07-18 17:30:25 -04:00
return -1;
}
channels = *pos++;
cl->channels = channels > P2P_MAX_REG_CLASS_CHANNELS ?
P2P_MAX_REG_CLASS_CHANNELS : channels;
os_memcpy(cl->channel, pos, cl->channels);
pos += channels;
ch->reg_classes++;
if (ch->reg_classes == P2P_MAX_REG_CLASSES)
break;
}
p2p_channels_intersect(own, &dev->channels, &intersection);
p2p_dbg(p2p, "Own reg_classes %d peer reg_classes %d intersection reg_classes %d",
2010-07-18 17:30:25 -04:00
(int) own->reg_classes,
(int) dev->channels.reg_classes,
(int) intersection.reg_classes);
if (intersection.reg_classes == 0) {
p2p_info(p2p, "No common channels found");
2010-07-18 17:30:25 -04:00
return -1;
}
return 0;
}
static int p2p_peer_channels(struct p2p_data *p2p, struct p2p_device *dev,
const u8 *channel_list, size_t channel_list_len)
{
return p2p_peer_channels_check(p2p, &p2p->channels, dev,
channel_list, channel_list_len);
}
u16 p2p_wps_method_pw_id(enum p2p_wps_method wps_method)
2010-07-18 17:30:25 -04:00
{
switch (wps_method) {
case WPS_PIN_DISPLAY:
return DEV_PW_REGISTRAR_SPECIFIED;
case WPS_PIN_KEYPAD:
return DEV_PW_USER_SPECIFIED;
case WPS_PBC:
return DEV_PW_PUSHBUTTON;
default:
return DEV_PW_DEFAULT;
}
}
static const char * p2p_wps_method_str(enum p2p_wps_method wps_method)
{
switch (wps_method) {
case WPS_PIN_DISPLAY:
return "Display";
case WPS_PIN_KEYPAD:
return "Keypad";
case WPS_PBC:
return "PBC";
default:
return "??";
}
}
static struct wpabuf * p2p_build_go_neg_req(struct p2p_data *p2p,
struct p2p_device *peer)
{
struct wpabuf *buf;
u8 *len;
u8 group_capab;
size_t extra = 0;
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_WIFI_DISPLAY
if (p2p->wfd_ie_go_neg)
extra = wpabuf_len(p2p->wfd_ie_go_neg);
#endif /* CONFIG_WIFI_DISPLAY */
buf = wpabuf_alloc(1000 + extra);
2010-07-18 17:30:25 -04:00
if (buf == NULL)
return NULL;
p2p_buf_add_public_action_hdr(buf, P2P_GO_NEG_REQ, peer->dialog_token);
len = p2p_buf_add_ie_hdr(buf);
group_capab = 0;
if (peer->flags & P2P_DEV_PREFER_PERSISTENT_GROUP) {
2010-07-18 17:30:25 -04:00
group_capab |= P2P_GROUP_CAPAB_PERSISTENT_GROUP;
if (peer->flags & P2P_DEV_PREFER_PERSISTENT_RECONN)
group_capab |= P2P_GROUP_CAPAB_PERSISTENT_RECONN;
}
if (p2p->cross_connect)
group_capab |= P2P_GROUP_CAPAB_CROSS_CONN;
if (p2p->cfg->p2p_intra_bss)
group_capab |= P2P_GROUP_CAPAB_INTRA_BSS_DIST;
p2p_buf_add_capability(buf, p2p->dev_capab &
~P2P_DEV_CAPAB_CLIENT_DISCOVERABILITY,
group_capab);
p2p_buf_add_go_intent(buf, (p2p->go_intent << 1) | peer->tie_breaker);
p2p_buf_add_config_timeout(buf, p2p->go_timeout, p2p->client_timeout);
2010-07-18 17:30:25 -04:00
p2p_buf_add_listen_channel(buf, p2p->cfg->country, p2p->cfg->reg_class,
p2p->cfg->channel);
if (p2p->ext_listen_interval)
p2p_buf_add_ext_listen_timing(buf, p2p->ext_listen_period,
p2p->ext_listen_interval);
p2p_buf_add_intended_addr(buf, p2p->intended_addr);
p2p_buf_add_channel_list(buf, p2p->cfg->country, &p2p->channels);
p2p_buf_add_device_info(buf, p2p, peer);
p2p_buf_add_operating_channel(buf, p2p->cfg->country,
p2p->op_reg_class, p2p->op_channel);
p2p_buf_update_ie_hdr(buf, len);
/* WPS IE with Device Password ID attribute */
if (p2p_build_wps_ie(p2p, buf, p2p_wps_method_pw_id(peer->wps_method),
0) < 0) {
p2p_dbg(p2p, "Failed to build WPS IE for GO Negotiation Request");
wpabuf_free(buf);
return NULL;
}
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_WIFI_DISPLAY
if (p2p->wfd_ie_go_neg)
wpabuf_put_buf(buf, p2p->wfd_ie_go_neg);
#endif /* CONFIG_WIFI_DISPLAY */
2010-07-18 17:30:25 -04:00
return buf;
}
int p2p_connect_send(struct p2p_data *p2p, struct p2p_device *dev)
{
struct wpabuf *req;
int freq;
if (dev->flags & P2P_DEV_PD_BEFORE_GO_NEG) {
u16 config_method;
p2p_dbg(p2p, "Use PD-before-GO-Neg workaround for " MACSTR,
MAC2STR(dev->info.p2p_device_addr));
if (dev->wps_method == WPS_PIN_DISPLAY)
config_method = WPS_CONFIG_KEYPAD;
else if (dev->wps_method == WPS_PIN_KEYPAD)
config_method = WPS_CONFIG_DISPLAY;
else if (dev->wps_method == WPS_PBC)
config_method = WPS_CONFIG_PUSHBUTTON;
else
return -1;
return p2p_prov_disc_req(p2p, dev->info.p2p_device_addr,
config_method, 0, 0, 1);
}
2010-07-18 17:30:25 -04:00
freq = dev->listen_freq > 0 ? dev->listen_freq : dev->oper_freq;
if (freq <= 0) {
p2p_dbg(p2p, "No Listen/Operating frequency known for the peer "
MACSTR " to send GO Negotiation Request",
MAC2STR(dev->info.p2p_device_addr));
2010-07-18 17:30:25 -04:00
return -1;
}
req = p2p_build_go_neg_req(p2p, dev);
if (req == NULL)
return -1;
p2p_dbg(p2p, "Sending GO Negotiation Request");
2010-07-18 17:30:25 -04:00
p2p_set_state(p2p, P2P_CONNECT);
p2p->pending_action_state = P2P_PENDING_GO_NEG_REQUEST;
p2p->go_neg_peer = dev;
dev->flags |= P2P_DEV_WAIT_GO_NEG_RESPONSE;
dev->connect_reqs++;
if (p2p_send_action(p2p, freq, dev->info.p2p_device_addr,
p2p->cfg->dev_addr, dev->info.p2p_device_addr,
wpabuf_head(req), wpabuf_len(req), 500) < 0) {
p2p_dbg(p2p, "Failed to send Action frame");
2010-07-18 17:30:25 -04:00
/* Use P2P find to recover and retry */
p2p_set_timeout(p2p, 0, 0);
} else
dev->go_neg_req_sent++;
2010-07-18 17:30:25 -04:00
wpabuf_free(req);
return 0;
}
static struct wpabuf * p2p_build_go_neg_resp(struct p2p_data *p2p,
struct p2p_device *peer,
u8 dialog_token, u8 status,
u8 tie_breaker)
{
struct wpabuf *buf;
u8 *len;
u8 group_capab;
size_t extra = 0;
2010-07-18 17:30:25 -04:00
p2p_dbg(p2p, "Building GO Negotiation Response");
#ifdef CONFIG_WIFI_DISPLAY
if (p2p->wfd_ie_go_neg)
extra = wpabuf_len(p2p->wfd_ie_go_neg);
#endif /* CONFIG_WIFI_DISPLAY */
buf = wpabuf_alloc(1000 + extra);
2010-07-18 17:30:25 -04:00
if (buf == NULL)
return NULL;
p2p_buf_add_public_action_hdr(buf, P2P_GO_NEG_RESP, dialog_token);
len = p2p_buf_add_ie_hdr(buf);
p2p_buf_add_status(buf, status);
group_capab = 0;
if (peer && peer->go_state == LOCAL_GO) {
if (peer->flags & P2P_DEV_PREFER_PERSISTENT_GROUP) {
group_capab |= P2P_GROUP_CAPAB_PERSISTENT_GROUP;
if (peer->flags & P2P_DEV_PREFER_PERSISTENT_RECONN)
group_capab |=
P2P_GROUP_CAPAB_PERSISTENT_RECONN;
}
if (p2p->cross_connect)
group_capab |= P2P_GROUP_CAPAB_CROSS_CONN;
if (p2p->cfg->p2p_intra_bss)
group_capab |= P2P_GROUP_CAPAB_INTRA_BSS_DIST;
}
p2p_buf_add_capability(buf, p2p->dev_capab &
~P2P_DEV_CAPAB_CLIENT_DISCOVERABILITY,
group_capab);
2010-07-18 17:30:25 -04:00
p2p_buf_add_go_intent(buf, (p2p->go_intent << 1) | tie_breaker);
p2p_buf_add_config_timeout(buf, p2p->go_timeout, p2p->client_timeout);
2010-07-18 17:30:25 -04:00
if (peer && peer->go_state == REMOTE_GO) {
p2p_dbg(p2p, "Omit Operating Channel attribute");
2010-07-18 17:30:25 -04:00
} else {
p2p_buf_add_operating_channel(buf, p2p->cfg->country,
p2p->op_reg_class,
p2p->op_channel);
}
p2p_buf_add_intended_addr(buf, p2p->intended_addr);
if (status || peer == NULL) {
p2p_buf_add_channel_list(buf, p2p->cfg->country,
&p2p->channels);
} else if (peer->go_state == REMOTE_GO) {
p2p_buf_add_channel_list(buf, p2p->cfg->country,
&p2p->channels);
} else {
struct p2p_channels res;
p2p_channels_intersect(&p2p->channels, &peer->channels,
&res);
p2p_buf_add_channel_list(buf, p2p->cfg->country, &res);
}
p2p_buf_add_device_info(buf, p2p, peer);
if (peer && peer->go_state == LOCAL_GO) {
p2p_buf_add_group_id(buf, p2p->cfg->dev_addr, p2p->ssid,
p2p->ssid_len);
}
p2p_buf_update_ie_hdr(buf, len);
/* WPS IE with Device Password ID attribute */
if (p2p_build_wps_ie(p2p, buf,
p2p_wps_method_pw_id(peer ? peer->wps_method :
WPS_NOT_READY), 0) < 0) {
p2p_dbg(p2p, "Failed to build WPS IE for GO Negotiation Response");
wpabuf_free(buf);
return NULL;
}
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_WIFI_DISPLAY
if (p2p->wfd_ie_go_neg)
wpabuf_put_buf(buf, p2p->wfd_ie_go_neg);
#endif /* CONFIG_WIFI_DISPLAY */
2010-07-18 17:30:25 -04:00
return buf;
}
/**
* p2p_reselect_channel - Re-select operating channel based on peer information
* @p2p: P2P module context from p2p_init()
* @intersection: Support channel list intersection from local and peer
*
* This function is used to re-select the best channel after having received
* information from the peer to allow supported channel lists to be intersected.
* This can be used to improve initial channel selection done in
* p2p_prepare_channel() prior to the start of GO Negotiation. In addition, this
* can be used for Invitation case.
*/
void p2p_reselect_channel(struct p2p_data *p2p,
struct p2p_channels *intersection)
{
struct p2p_reg_class *cl;
int freq;
u8 op_reg_class, op_channel;
unsigned int i;
const int op_classes_5ghz[] = { 124, 115, 0 };
const int op_classes_ht40[] = { 126, 127, 116, 117, 0 };
const int op_classes_vht[] = { 128, 0 };
if (p2p->own_freq_preference > 0 &&
p2p_freq_to_channel(p2p->own_freq_preference,
&op_reg_class, &op_channel) == 0 &&
p2p_channels_includes(intersection, op_reg_class, op_channel)) {
p2p_dbg(p2p, "Pick own channel preference (reg_class %u channel %u) from intersection",
op_reg_class, op_channel);
p2p->op_reg_class = op_reg_class;
p2p->op_channel = op_channel;
return;
}
if (p2p->best_freq_overall > 0 &&
p2p_freq_to_channel(p2p->best_freq_overall,
&op_reg_class, &op_channel) == 0 &&
p2p_channels_includes(intersection, op_reg_class, op_channel)) {
p2p_dbg(p2p, "Pick best overall channel (reg_class %u channel %u) from intersection",
op_reg_class, op_channel);
p2p->op_reg_class = op_reg_class;
p2p->op_channel = op_channel;
return;
}
/* First, try to pick the best channel from another band */
freq = p2p_channel_to_freq(p2p->op_reg_class, p2p->op_channel);
if (freq >= 2400 && freq < 2500 && p2p->best_freq_5 > 0 &&
!p2p_channels_includes(intersection, p2p->op_reg_class,
p2p->op_channel) &&
p2p_freq_to_channel(p2p->best_freq_5,
&op_reg_class, &op_channel) == 0 &&
p2p_channels_includes(intersection, op_reg_class, op_channel)) {
p2p_dbg(p2p, "Pick best 5 GHz channel (reg_class %u channel %u) from intersection",
op_reg_class, op_channel);
p2p->op_reg_class = op_reg_class;
p2p->op_channel = op_channel;
return;
}
if (freq >= 4900 && freq < 6000 && p2p->best_freq_24 > 0 &&
!p2p_channels_includes(intersection, p2p->op_reg_class,
p2p->op_channel) &&
p2p_freq_to_channel(p2p->best_freq_24,
&op_reg_class, &op_channel) == 0 &&
p2p_channels_includes(intersection, op_reg_class, op_channel)) {
p2p_dbg(p2p, "Pick best 2.4 GHz channel (reg_class %u channel %u) from intersection",
op_reg_class, op_channel);
p2p->op_reg_class = op_reg_class;
p2p->op_channel = op_channel;
return;
}
/* Select channel with highest preference if the peer supports it */
for (i = 0; p2p->cfg->pref_chan && i < p2p->cfg->num_pref_chan; i++) {
if (p2p_channels_includes(intersection,
p2p->cfg->pref_chan[i].op_class,
p2p->cfg->pref_chan[i].chan)) {
p2p->op_reg_class = p2p->cfg->pref_chan[i].op_class;
p2p->op_channel = p2p->cfg->pref_chan[i].chan;
p2p_dbg(p2p, "Pick highest preferred channel (op_class %u channel %u) from intersection",
p2p->op_reg_class, p2p->op_channel);
return;
}
}
/* Try a channel where we might be able to use VHT */
if (p2p_channel_select(intersection, op_classes_vht,
&p2p->op_reg_class, &p2p->op_channel) == 0) {
p2p_dbg(p2p, "Pick possible VHT channel (op_class %u channel %u) from intersection",
p2p->op_reg_class, p2p->op_channel);
return;
}
/* Try a channel where we might be able to use HT40 */
if (p2p_channel_select(intersection, op_classes_ht40,
&p2p->op_reg_class, &p2p->op_channel) == 0) {
p2p_dbg(p2p, "Pick possible HT40 channel (op_class %u channel %u) from intersection",
p2p->op_reg_class, p2p->op_channel);
return;
}
/* Prefer a 5 GHz channel */
if (p2p_channel_select(intersection, op_classes_5ghz,
&p2p->op_reg_class, &p2p->op_channel) == 0) {
p2p_dbg(p2p, "Pick possible 5 GHz channel (op_class %u channel %u) from intersection",
p2p->op_reg_class, p2p->op_channel);
return;
}
/*
* Try to see if the original channel is in the intersection. If
* so, no need to change anything, as it already contains some
* randomness.
*/
if (p2p_channels_includes(intersection, p2p->op_reg_class,
p2p->op_channel)) {
p2p_dbg(p2p, "Using original operating class and channel (op_class %u channel %u) from intersection",
p2p->op_reg_class, p2p->op_channel);
return;
}
/*
* Fall back to whatever is included in the channel intersection since
* no better options seems to be available.
*/
cl = &intersection->reg_class[0];
p2p_dbg(p2p, "Pick another channel (reg_class %u channel %u) from intersection",
cl->reg_class, cl->channel[0]);
p2p->op_reg_class = cl->reg_class;
p2p->op_channel = cl->channel[0];
}
static int p2p_go_select_channel(struct p2p_data *p2p, struct p2p_device *dev,
u8 *status)
{
struct p2p_channels tmp, intersection;
p2p_channels_dump(p2p, "own channels", &p2p->channels);
p2p_channels_dump(p2p, "peer channels", &dev->channels);
p2p_channels_intersect(&p2p->channels, &dev->channels, &tmp);
p2p_channels_dump(p2p, "intersection", &tmp);
p2p_channels_remove_freqs(&tmp, &p2p->no_go_freq);
p2p_channels_dump(p2p, "intersection after no-GO removal", &tmp);
p2p_channels_intersect(&tmp, &p2p->cfg->channels, &intersection);
p2p_channels_dump(p2p, "intersection with local channel list",
&intersection);
if (intersection.reg_classes == 0 ||
intersection.reg_class[0].channels == 0) {
*status = P2P_SC_FAIL_NO_COMMON_CHANNELS;
p2p_dbg(p2p, "No common channels found");
return -1;
}
if (!p2p_channels_includes(&intersection, p2p->op_reg_class,
p2p->op_channel)) {
if (dev->flags & P2P_DEV_FORCE_FREQ) {
*status = P2P_SC_FAIL_NO_COMMON_CHANNELS;
p2p_dbg(p2p, "Peer does not support the forced channel");
return -1;
}
p2p_dbg(p2p, "Selected operating channel (op_class %u channel %u) not acceptable to the peer",
p2p->op_reg_class, p2p->op_channel);
p2p_reselect_channel(p2p, &intersection);
} else if (!(dev->flags & P2P_DEV_FORCE_FREQ) &&
!p2p->cfg->cfg_op_channel) {
p2p_dbg(p2p, "Try to optimize channel selection with peer information received; previously selected op_class %u channel %u",
p2p->op_reg_class, p2p->op_channel);
p2p_reselect_channel(p2p, &intersection);
}
if (!p2p->ssid_set) {
p2p_build_ssid(p2p, p2p->ssid, &p2p->ssid_len);
p2p->ssid_set = 1;
}
return 0;
}
2010-07-18 17:30:25 -04:00
void p2p_process_go_neg_req(struct p2p_data *p2p, const u8 *sa,
const u8 *data, size_t len, int rx_freq)
{
struct p2p_device *dev = NULL;
struct wpabuf *resp;
struct p2p_message msg;
u8 status = P2P_SC_FAIL_INVALID_PARAMS;
int tie_breaker = 0;
int freq;
p2p_dbg(p2p, "Received GO Negotiation Request from " MACSTR "(freq=%d)",
MAC2STR(sa), rx_freq);
2010-07-18 17:30:25 -04:00
if (p2p_parse(data, len, &msg))
return;
if (!msg.capability) {
p2p_dbg(p2p, "Mandatory Capability attribute missing from GO Negotiation Request");
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_P2P_STRICT
goto fail;
#endif /* CONFIG_P2P_STRICT */
}
if (msg.go_intent)
tie_breaker = *msg.go_intent & 0x01;
else {
p2p_dbg(p2p, "Mandatory GO Intent attribute missing from GO Negotiation Request");
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_P2P_STRICT
goto fail;
#endif /* CONFIG_P2P_STRICT */
}
if (!msg.config_timeout) {
p2p_dbg(p2p, "Mandatory Configuration Timeout attribute missing from GO Negotiation Request");
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_P2P_STRICT
goto fail;
#endif /* CONFIG_P2P_STRICT */
}
if (!msg.listen_channel) {
p2p_dbg(p2p, "No Listen Channel attribute received");
2010-07-18 17:30:25 -04:00
goto fail;
}
if (!msg.operating_channel) {
p2p_dbg(p2p, "No Operating Channel attribute received");
2010-07-18 17:30:25 -04:00
goto fail;
}
if (!msg.channel_list) {
p2p_dbg(p2p, "No Channel List attribute received");
2010-07-18 17:30:25 -04:00
goto fail;
}
if (!msg.intended_addr) {
p2p_dbg(p2p, "No Intended P2P Interface Address attribute received");
2010-07-18 17:30:25 -04:00
goto fail;
}
if (!msg.p2p_device_info) {
p2p_dbg(p2p, "No P2P Device Info attribute received");
2010-07-18 17:30:25 -04:00
goto fail;
}
if (os_memcmp(msg.p2p_device_addr, sa, ETH_ALEN) != 0) {
p2p_dbg(p2p, "Unexpected GO Negotiation Request SA=" MACSTR
2010-07-18 17:30:25 -04:00
" != dev_addr=" MACSTR,
MAC2STR(sa), MAC2STR(msg.p2p_device_addr));
goto fail;
}
dev = p2p_get_device(p2p, sa);
if (msg.status && *msg.status) {
p2p_dbg(p2p, "Unexpected Status attribute (%d) in GO Negotiation Request",
*msg.status);
2010-07-18 17:30:25 -04:00
goto fail;
}
if (dev == NULL)
dev = p2p_add_dev_from_go_neg_req(p2p, sa, &msg);
else if (dev->flags & P2P_DEV_PROBE_REQ_ONLY)
p2p_add_dev_info(p2p, sa, dev, &msg);
if (dev && dev->flags & P2P_DEV_USER_REJECTED) {
p2p_dbg(p2p, "User has rejected this peer");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_REJECTED_BY_USER;
} else if (dev == NULL || dev->wps_method == WPS_NOT_READY) {
p2p_dbg(p2p, "Not ready for GO negotiation with " MACSTR,
2010-07-18 17:30:25 -04:00
MAC2STR(sa));
status = P2P_SC_FAIL_INFO_CURRENTLY_UNAVAILABLE;
p2p->cfg->go_neg_req_rx(p2p->cfg->cb_ctx, sa,
msg.dev_password_id);
2010-07-18 17:30:25 -04:00
} else if (p2p->go_neg_peer && p2p->go_neg_peer != dev) {
p2p_dbg(p2p, "Already in Group Formation with another peer");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_UNABLE_TO_ACCOMMODATE;
} else {
int go;
if (!p2p->go_neg_peer) {
p2p_dbg(p2p, "Starting GO Negotiation with previously authorized peer");
if (!(dev->flags & P2P_DEV_FORCE_FREQ)) {
p2p_dbg(p2p, "Use default channel settings");
p2p->op_reg_class = p2p->cfg->op_reg_class;
p2p->op_channel = p2p->cfg->op_channel;
os_memcpy(&p2p->channels, &p2p->cfg->channels,
sizeof(struct p2p_channels));
} else {
p2p_dbg(p2p, "Use previously configured forced channel settings");
}
2010-07-18 17:30:25 -04:00
}
dev->flags &= ~P2P_DEV_NOT_YET_READY;
if (!msg.go_intent) {
p2p_dbg(p2p, "No GO Intent attribute received");
2010-07-18 17:30:25 -04:00
goto fail;
}
if ((*msg.go_intent >> 1) > P2P_MAX_GO_INTENT) {
p2p_dbg(p2p, "Invalid GO Intent value (%u) received",
2010-07-18 17:30:25 -04:00
*msg.go_intent >> 1);
goto fail;
}
if (dev->go_neg_req_sent &&
os_memcmp(sa, p2p->cfg->dev_addr, ETH_ALEN) > 0) {
p2p_dbg(p2p, "Do not reply since peer has higher address and GO Neg Request already sent");
2010-07-18 17:30:25 -04:00
p2p_parse_free(&msg);
return;
}
go = p2p_go_det(p2p->go_intent, *msg.go_intent);
if (go < 0) {
p2p_dbg(p2p, "Incompatible GO Intent");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_BOTH_GO_INTENT_15;
goto fail;
}
if (p2p_peer_channels(p2p, dev, msg.channel_list,
msg.channel_list_len) < 0) {
p2p_dbg(p2p, "No common channels found");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_NO_COMMON_CHANNELS;
goto fail;
}
switch (msg.dev_password_id) {
case DEV_PW_REGISTRAR_SPECIFIED:
p2p_dbg(p2p, "PIN from peer Display");
2010-07-18 17:30:25 -04:00
if (dev->wps_method != WPS_PIN_KEYPAD) {
p2p_dbg(p2p, "We have wps_method=%s -> incompatible",
2010-07-18 17:30:25 -04:00
p2p_wps_method_str(dev->wps_method));
status = P2P_SC_FAIL_INCOMPATIBLE_PROV_METHOD;
goto fail;
}
break;
case DEV_PW_USER_SPECIFIED:
p2p_dbg(p2p, "Peer entered PIN on Keypad");
if (dev->wps_method != WPS_PIN_DISPLAY) {
p2p_dbg(p2p, "We have wps_method=%s -> incompatible",
2010-07-18 17:30:25 -04:00
p2p_wps_method_str(dev->wps_method));
status = P2P_SC_FAIL_INCOMPATIBLE_PROV_METHOD;
goto fail;
}
break;
case DEV_PW_PUSHBUTTON:
p2p_dbg(p2p, "Peer using pushbutton");
2010-07-18 17:30:25 -04:00
if (dev->wps_method != WPS_PBC) {
p2p_dbg(p2p, "We have wps_method=%s -> incompatible",
2010-07-18 17:30:25 -04:00
p2p_wps_method_str(dev->wps_method));
status = P2P_SC_FAIL_INCOMPATIBLE_PROV_METHOD;
goto fail;
}
break;
default:
p2p_dbg(p2p, "Unsupported Device Password ID %d",
2010-07-18 17:30:25 -04:00
msg.dev_password_id);
status = P2P_SC_FAIL_INCOMPATIBLE_PROV_METHOD;
goto fail;
}
if (go && p2p_go_select_channel(p2p, dev, &status) < 0)
goto fail;
2010-07-18 17:30:25 -04:00
dev->go_state = go ? LOCAL_GO : REMOTE_GO;
dev->oper_freq = p2p_channel_to_freq(msg.operating_channel[3],
2010-07-18 17:30:25 -04:00
msg.operating_channel[4]);
p2p_dbg(p2p, "Peer operating channel preference: %d MHz",
dev->oper_freq);
2010-07-18 17:30:25 -04:00
if (msg.config_timeout) {
dev->go_timeout = msg.config_timeout[0];
dev->client_timeout = msg.config_timeout[1];
}
p2p_dbg(p2p, "GO Negotiation with " MACSTR, MAC2STR(sa));
2010-07-18 17:30:25 -04:00
if (p2p->state != P2P_IDLE)
p2p_stop_find_for_freq(p2p, rx_freq);
2010-07-18 17:30:25 -04:00
p2p_set_state(p2p, P2P_GO_NEG);
p2p_clear_timeout(p2p);
dev->dialog_token = msg.dialog_token;
os_memcpy(dev->intended_addr, msg.intended_addr, ETH_ALEN);
p2p->go_neg_peer = dev;
status = P2P_SC_SUCCESS;
}
fail:
if (dev)
dev->status = status;
2010-07-18 17:30:25 -04:00
resp = p2p_build_go_neg_resp(p2p, dev, msg.dialog_token, status,
!tie_breaker);
p2p_parse_free(&msg);
if (resp == NULL)
return;
p2p_dbg(p2p, "Sending GO Negotiation Response");
2010-07-18 17:30:25 -04:00
if (rx_freq > 0)
freq = rx_freq;
else
freq = p2p_channel_to_freq(p2p->cfg->reg_class,
2010-07-18 17:30:25 -04:00
p2p->cfg->channel);
if (freq < 0) {
p2p_dbg(p2p, "Unknown regulatory class/channel");
2010-07-18 17:30:25 -04:00
wpabuf_free(resp);
return;
}
if (status == P2P_SC_SUCCESS) {
p2p->pending_action_state = P2P_PENDING_GO_NEG_RESPONSE;
dev->flags |= P2P_DEV_WAIT_GO_NEG_CONFIRM;
if (os_memcmp(sa, p2p->cfg->dev_addr, ETH_ALEN) < 0) {
/*
* Peer has smaller address, so the GO Negotiation
* Response from us is expected to complete
* negotiation. Ignore a GO Negotiation Response from
* the peer if it happens to be received after this
* point due to a race condition in GO Negotiation
* Request transmission and processing.
*/
dev->flags &= ~P2P_DEV_WAIT_GO_NEG_RESPONSE;
}
2010-07-18 17:30:25 -04:00
} else
p2p->pending_action_state =
P2P_PENDING_GO_NEG_RESPONSE_FAILURE;
if (p2p_send_action(p2p, freq, sa, p2p->cfg->dev_addr,
p2p->cfg->dev_addr,
wpabuf_head(resp), wpabuf_len(resp), 500) < 0) {
p2p_dbg(p2p, "Failed to send Action frame");
2010-07-18 17:30:25 -04:00
}
wpabuf_free(resp);
}
static struct wpabuf * p2p_build_go_neg_conf(struct p2p_data *p2p,
struct p2p_device *peer,
u8 dialog_token, u8 status,
const u8 *resp_chan, int go)
{
struct wpabuf *buf;
u8 *len;
struct p2p_channels res;
u8 group_capab;
size_t extra = 0;
2010-07-18 17:30:25 -04:00
p2p_dbg(p2p, "Building GO Negotiation Confirm");
#ifdef CONFIG_WIFI_DISPLAY
if (p2p->wfd_ie_go_neg)
extra = wpabuf_len(p2p->wfd_ie_go_neg);
#endif /* CONFIG_WIFI_DISPLAY */
buf = wpabuf_alloc(1000 + extra);
2010-07-18 17:30:25 -04:00
if (buf == NULL)
return NULL;
p2p_buf_add_public_action_hdr(buf, P2P_GO_NEG_CONF, dialog_token);
len = p2p_buf_add_ie_hdr(buf);
p2p_buf_add_status(buf, status);
group_capab = 0;
if (peer->go_state == LOCAL_GO) {
if (peer->flags & P2P_DEV_PREFER_PERSISTENT_GROUP) {
group_capab |= P2P_GROUP_CAPAB_PERSISTENT_GROUP;
if (peer->flags & P2P_DEV_PREFER_PERSISTENT_RECONN)
group_capab |=
P2P_GROUP_CAPAB_PERSISTENT_RECONN;
}
if (p2p->cross_connect)
group_capab |= P2P_GROUP_CAPAB_CROSS_CONN;
if (p2p->cfg->p2p_intra_bss)
group_capab |= P2P_GROUP_CAPAB_INTRA_BSS_DIST;
}
p2p_buf_add_capability(buf, p2p->dev_capab &
~P2P_DEV_CAPAB_CLIENT_DISCOVERABILITY,
group_capab);
2010-07-18 17:30:25 -04:00
if (go || resp_chan == NULL)
p2p_buf_add_operating_channel(buf, p2p->cfg->country,
p2p->op_reg_class,
p2p->op_channel);
else
p2p_buf_add_operating_channel(buf, (const char *) resp_chan,
resp_chan[3], resp_chan[4]);
p2p_channels_intersect(&p2p->channels, &peer->channels, &res);
p2p_buf_add_channel_list(buf, p2p->cfg->country, &res);
if (go) {
p2p_buf_add_group_id(buf, p2p->cfg->dev_addr, p2p->ssid,
p2p->ssid_len);
}
p2p_buf_update_ie_hdr(buf, len);
#ifdef CONFIG_WIFI_DISPLAY
if (p2p->wfd_ie_go_neg)
wpabuf_put_buf(buf, p2p->wfd_ie_go_neg);
#endif /* CONFIG_WIFI_DISPLAY */
2010-07-18 17:30:25 -04:00
return buf;
}
void p2p_process_go_neg_resp(struct p2p_data *p2p, const u8 *sa,
const u8 *data, size_t len, int rx_freq)
{
struct p2p_device *dev;
struct wpabuf *conf;
int go = -1;
struct p2p_message msg;
u8 status = P2P_SC_SUCCESS;
int freq;
p2p_dbg(p2p, "Received GO Negotiation Response from " MACSTR
2010-07-18 17:30:25 -04:00
" (freq=%d)", MAC2STR(sa), rx_freq);
dev = p2p_get_device(p2p, sa);
if (dev == NULL || dev->wps_method == WPS_NOT_READY ||
dev != p2p->go_neg_peer) {
p2p_dbg(p2p, "Not ready for GO negotiation with " MACSTR,
2010-07-18 17:30:25 -04:00
MAC2STR(sa));
return;
}
if (p2p_parse(data, len, &msg))
return;
if (!(dev->flags & P2P_DEV_WAIT_GO_NEG_RESPONSE)) {
p2p_dbg(p2p, "Was not expecting GO Negotiation Response - ignore");
2010-07-18 17:30:25 -04:00
p2p_parse_free(&msg);
return;
}
dev->flags &= ~P2P_DEV_WAIT_GO_NEG_RESPONSE;
if (msg.dialog_token != dev->dialog_token) {
p2p_dbg(p2p, "Unexpected Dialog Token %u (expected %u)",
2010-07-18 17:30:25 -04:00
msg.dialog_token, dev->dialog_token);
p2p_parse_free(&msg);
return;
}
if (!msg.status) {
p2p_dbg(p2p, "No Status attribute received");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
}
if (*msg.status) {
p2p_dbg(p2p, "GO Negotiation rejected: status %d", *msg.status);
2010-07-18 17:30:25 -04:00
dev->go_neg_req_sent = 0;
if (*msg.status == P2P_SC_FAIL_INFO_CURRENTLY_UNAVAILABLE) {
p2p_dbg(p2p, "Wait for the peer to become ready for GO Negotiation");
2010-07-18 17:30:25 -04:00
dev->flags |= P2P_DEV_NOT_YET_READY;
dev->wait_count = 0;
p2p_set_state(p2p, P2P_WAIT_PEER_IDLE);
p2p_set_timeout(p2p, 0, 0);
} else {
p2p_dbg(p2p, "Stop GO Negotiation attempt");
2010-07-18 17:30:25 -04:00
p2p_go_neg_failed(p2p, dev, *msg.status);
}
p2p->cfg->send_action_done(p2p->cfg->cb_ctx);
p2p_parse_free(&msg);
return;
}
if (!msg.capability) {
p2p_dbg(p2p, "Mandatory Capability attribute missing from GO Negotiation Response");
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_P2P_STRICT
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
#endif /* CONFIG_P2P_STRICT */
}
if (!msg.p2p_device_info) {
p2p_dbg(p2p, "Mandatory P2P Device Info attribute missing from GO Negotiation Response");
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_P2P_STRICT
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
#endif /* CONFIG_P2P_STRICT */
}
if (!msg.intended_addr) {
p2p_dbg(p2p, "No Intended P2P Interface Address attribute received");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
}
if (!msg.go_intent) {
p2p_dbg(p2p, "No GO Intent attribute received");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
}
if ((*msg.go_intent >> 1) > P2P_MAX_GO_INTENT) {
p2p_dbg(p2p, "Invalid GO Intent value (%u) received",
2010-07-18 17:30:25 -04:00
*msg.go_intent >> 1);
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
}
go = p2p_go_det(p2p->go_intent, *msg.go_intent);
if (go < 0) {
p2p_dbg(p2p, "Incompatible GO Intent");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_INCOMPATIBLE_PARAMS;
goto fail;
}
if (!go && msg.group_id) {
/* Store SSID for Provisioning step */
p2p->ssid_len = msg.group_id_len - ETH_ALEN;
os_memcpy(p2p->ssid, msg.group_id + ETH_ALEN, p2p->ssid_len);
2010-07-18 17:30:25 -04:00
} else if (!go) {
p2p_dbg(p2p, "Mandatory P2P Group ID attribute missing from GO Negotiation Response");
p2p->ssid_len = 0;
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
}
if (!msg.config_timeout) {
p2p_dbg(p2p, "Mandatory Configuration Timeout attribute missing from GO Negotiation Response");
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_P2P_STRICT
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
#endif /* CONFIG_P2P_STRICT */
} else {
dev->go_timeout = msg.config_timeout[0];
dev->client_timeout = msg.config_timeout[1];
2010-07-18 17:30:25 -04:00
}
if (!msg.operating_channel && !go) {
/*
* Note: P2P Client may omit Operating Channel attribute to
* indicate it does not have a preference.
*/
p2p_dbg(p2p, "No Operating Channel attribute received");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
}
if (!msg.channel_list) {
p2p_dbg(p2p, "No Channel List attribute received");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_INVALID_PARAMS;
goto fail;
}
if (p2p_peer_channels(p2p, dev, msg.channel_list,
msg.channel_list_len) < 0) {
p2p_dbg(p2p, "No common channels found");
2010-07-18 17:30:25 -04:00
status = P2P_SC_FAIL_NO_COMMON_CHANNELS;
goto fail;
}
if (msg.operating_channel) {
dev->oper_freq = p2p_channel_to_freq(msg.operating_channel[3],
2010-07-18 17:30:25 -04:00
msg.operating_channel[4]);
p2p_dbg(p2p, "Peer operating channel preference: %d MHz",
dev->oper_freq);
2010-07-18 17:30:25 -04:00
} else
dev->oper_freq = 0;
switch (msg.dev_password_id) {
case DEV_PW_REGISTRAR_SPECIFIED:
p2p_dbg(p2p, "PIN from peer Display");
2010-07-18 17:30:25 -04:00
if (dev->wps_method != WPS_PIN_KEYPAD) {
p2p_dbg(p2p, "We have wps_method=%s -> incompatible",
2010-07-18 17:30:25 -04:00
p2p_wps_method_str(dev->wps_method));
status = P2P_SC_FAIL_INCOMPATIBLE_PROV_METHOD;
goto fail;
}
break;
case DEV_PW_USER_SPECIFIED:
p2p_dbg(p2p, "Peer entered PIN on Keypad");
if (dev->wps_method != WPS_PIN_DISPLAY) {
p2p_dbg(p2p, "We have wps_method=%s -> incompatible",
2010-07-18 17:30:25 -04:00
p2p_wps_method_str(dev->wps_method));
status = P2P_SC_FAIL_INCOMPATIBLE_PROV_METHOD;
goto fail;
}
break;
case DEV_PW_PUSHBUTTON:
p2p_dbg(p2p, "Peer using pushbutton");
2010-07-18 17:30:25 -04:00
if (dev->wps_method != WPS_PBC) {
p2p_dbg(p2p, "We have wps_method=%s -> incompatible",
2010-07-18 17:30:25 -04:00
p2p_wps_method_str(dev->wps_method));
status = P2P_SC_FAIL_INCOMPATIBLE_PROV_METHOD;
goto fail;
}
break;
default:
p2p_dbg(p2p, "Unsupported Device Password ID %d",
2010-07-18 17:30:25 -04:00
msg.dev_password_id);
status = P2P_SC_FAIL_INCOMPATIBLE_PROV_METHOD;
goto fail;
}
if (go && p2p_go_select_channel(p2p, dev, &status) < 0)
goto fail;
2010-07-18 17:30:25 -04:00
p2p_set_state(p2p, P2P_GO_NEG);
p2p_clear_timeout(p2p);
p2p_dbg(p2p, "GO Negotiation with " MACSTR, MAC2STR(sa));
2010-07-18 17:30:25 -04:00
os_memcpy(dev->intended_addr, msg.intended_addr, ETH_ALEN);
fail:
conf = p2p_build_go_neg_conf(p2p, dev, msg.dialog_token, status,
msg.operating_channel, go);
p2p_parse_free(&msg);
if (conf == NULL)
return;
p2p_dbg(p2p, "Sending GO Negotiation Confirm");
2010-07-18 17:30:25 -04:00
if (status == P2P_SC_SUCCESS) {
p2p->pending_action_state = P2P_PENDING_GO_NEG_CONFIRM;
dev->go_state = go ? LOCAL_GO : REMOTE_GO;
} else
p2p->pending_action_state = P2P_NO_PENDING_ACTION;
if (rx_freq > 0)
freq = rx_freq;
else
freq = dev->listen_freq;
if (p2p_send_action(p2p, freq, sa, p2p->cfg->dev_addr, sa,
wpabuf_head(conf), wpabuf_len(conf), 0) < 0) {
p2p_dbg(p2p, "Failed to send Action frame");
2010-07-18 17:30:25 -04:00
p2p_go_neg_failed(p2p, dev, -1);
p2p->cfg->send_action_done(p2p->cfg->cb_ctx);
2010-07-18 17:30:25 -04:00
}
wpabuf_free(conf);
if (status != P2P_SC_SUCCESS) {
p2p_dbg(p2p, "GO Negotiation failed");
p2p_go_neg_failed(p2p, dev, status);
}
2010-07-18 17:30:25 -04:00
}
void p2p_process_go_neg_conf(struct p2p_data *p2p, const u8 *sa,
const u8 *data, size_t len)
{
struct p2p_device *dev;
struct p2p_message msg;
p2p_dbg(p2p, "Received GO Negotiation Confirm from " MACSTR,
2010-07-18 17:30:25 -04:00
MAC2STR(sa));
dev = p2p_get_device(p2p, sa);
if (dev == NULL || dev->wps_method == WPS_NOT_READY ||
dev != p2p->go_neg_peer) {
p2p_dbg(p2p, "Not ready for GO negotiation with " MACSTR,
2010-07-18 17:30:25 -04:00
MAC2STR(sa));
return;
}
if (p2p->pending_action_state == P2P_PENDING_GO_NEG_RESPONSE) {
p2p_dbg(p2p, "Stopped waiting for TX status on GO Negotiation Response since we already received Confirmation");
2010-07-18 17:30:25 -04:00
p2p->pending_action_state = P2P_NO_PENDING_ACTION;
}
if (p2p_parse(data, len, &msg))
return;
if (!(dev->flags & P2P_DEV_WAIT_GO_NEG_CONFIRM)) {
p2p_dbg(p2p, "Was not expecting GO Negotiation Confirm - ignore");
2010-07-18 17:30:25 -04:00
return;
}
dev->flags &= ~P2P_DEV_WAIT_GO_NEG_CONFIRM;
p2p->cfg->send_action_done(p2p->cfg->cb_ctx);
2010-07-18 17:30:25 -04:00
if (msg.dialog_token != dev->dialog_token) {
p2p_dbg(p2p, "Unexpected Dialog Token %u (expected %u)",
2010-07-18 17:30:25 -04:00
msg.dialog_token, dev->dialog_token);
p2p_parse_free(&msg);
return;
}
if (!msg.status) {
p2p_dbg(p2p, "No Status attribute received");
2010-07-18 17:30:25 -04:00
p2p_parse_free(&msg);
return;
}
if (*msg.status) {
p2p_dbg(p2p, "GO Negotiation rejected: status %d", *msg.status);
p2p_go_neg_failed(p2p, dev, *msg.status);
2010-07-18 17:30:25 -04:00
p2p_parse_free(&msg);
return;
}
if (dev->go_state == REMOTE_GO && msg.group_id) {
/* Store SSID for Provisioning step */
p2p->ssid_len = msg.group_id_len - ETH_ALEN;
os_memcpy(p2p->ssid, msg.group_id + ETH_ALEN, p2p->ssid_len);
2010-07-18 17:30:25 -04:00
} else if (dev->go_state == REMOTE_GO) {
p2p_dbg(p2p, "Mandatory P2P Group ID attribute missing from GO Negotiation Confirmation");
p2p->ssid_len = 0;
p2p_go_neg_failed(p2p, dev, P2P_SC_FAIL_INVALID_PARAMS);
2010-07-18 17:30:25 -04:00
p2p_parse_free(&msg);
return;
}
if (!msg.operating_channel) {
p2p_dbg(p2p, "Mandatory Operating Channel attribute missing from GO Negotiation Confirmation");
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_P2P_STRICT
p2p_parse_free(&msg);
return;
#endif /* CONFIG_P2P_STRICT */
} else if (dev->go_state == REMOTE_GO) {
int oper_freq = p2p_channel_to_freq(msg.operating_channel[3],
msg.operating_channel[4]);
if (oper_freq != dev->oper_freq) {
p2p_dbg(p2p, "Updated peer (GO) operating channel preference from %d MHz to %d MHz",
dev->oper_freq, oper_freq);
dev->oper_freq = oper_freq;
}
2010-07-18 17:30:25 -04:00
}
if (!msg.channel_list) {
p2p_dbg(p2p, "Mandatory Operating Channel attribute missing from GO Negotiation Confirmation");
2010-07-18 17:30:25 -04:00
#ifdef CONFIG_P2P_STRICT
p2p_parse_free(&msg);
return;
#endif /* CONFIG_P2P_STRICT */
}
p2p_parse_free(&msg);
if (dev->go_state == UNKNOWN_GO) {
/*
* This should not happen since GO negotiation has already
* been completed.
*/
p2p_dbg(p2p, "Unexpected GO Neg state - do not know which end becomes GO");
2010-07-18 17:30:25 -04:00
return;
}
P2P: Improve robustness against lost ctrl::ack frames P2P includes two use cases where one of the devices is going to start a group and likely change channels immediately after processing a frame. This operation may be fast enough to make the device leave the current channel before the peer has completed layer 2 retransmission of the frame in case the ctrl::ack frame was lost. This can result in the peer not getting TX status success notification. For GO Negotiation Confirm frame, p2p_go_neg_conf_cb() has a workaround that ignores the TX status failure and will continue with the group formation with the assumption that the peer actually received the frame even though we did not receive ctrl::ack. For Invitation Response frame to re-invoke a persistent group, no such workaround is used in p2p_invitation_resp_cb(). Consequently, TX status failure due to lost ctrl::ack frame results in one of the peers not starting the group. Increase the likelihood of layer 2 retransmission getting acknowledged and ctrl::ack being received by waiting a short duration after having processed the GO Negotiation Confirm and Invitation Response frames for the re-invocation case. For the former, use 20 ms wait since this case has been worked around in deployed devices. For the latter, use 50 ms wait to get even higher likelihood of getting ctrl::ack through since deployed devices (and the current wpa_supplicant implementation) do not have a workaround to ignore TX status failure. 20 ms is long enough to include at least couple of retries and that should increase likelihood of getting ctrl::ack through quite a bit. The longer 50 ms wait is likely to include full set of layer 2 retries. Signed-hostap: Jouni Malinen <jouni@qca.qualcomm.com>
2012-10-13 10:33:16 -04:00
/*
* The peer could have missed our ctrl::ack frame for GO Negotiation
* Confirm and continue retransmitting the frame. To reduce the
* likelihood of the peer not getting successful TX status for the
* GO Negotiation Confirm frame, wait a short time here before starting
* the group so that we will remain on the current channel to
* acknowledge any possible retransmission from the peer.
*/
p2p_dbg(p2p, "20 ms wait on current channel before starting group");
P2P: Improve robustness against lost ctrl::ack frames P2P includes two use cases where one of the devices is going to start a group and likely change channels immediately after processing a frame. This operation may be fast enough to make the device leave the current channel before the peer has completed layer 2 retransmission of the frame in case the ctrl::ack frame was lost. This can result in the peer not getting TX status success notification. For GO Negotiation Confirm frame, p2p_go_neg_conf_cb() has a workaround that ignores the TX status failure and will continue with the group formation with the assumption that the peer actually received the frame even though we did not receive ctrl::ack. For Invitation Response frame to re-invoke a persistent group, no such workaround is used in p2p_invitation_resp_cb(). Consequently, TX status failure due to lost ctrl::ack frame results in one of the peers not starting the group. Increase the likelihood of layer 2 retransmission getting acknowledged and ctrl::ack being received by waiting a short duration after having processed the GO Negotiation Confirm and Invitation Response frames for the re-invocation case. For the former, use 20 ms wait since this case has been worked around in deployed devices. For the latter, use 50 ms wait to get even higher likelihood of getting ctrl::ack through since deployed devices (and the current wpa_supplicant implementation) do not have a workaround to ignore TX status failure. 20 ms is long enough to include at least couple of retries and that should increase likelihood of getting ctrl::ack through quite a bit. The longer 50 ms wait is likely to include full set of layer 2 retries. Signed-hostap: Jouni Malinen <jouni@qca.qualcomm.com>
2012-10-13 10:33:16 -04:00
os_sleep(0, 20000);
2010-07-18 17:30:25 -04:00
p2p_go_complete(p2p, dev);
}